Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Docs refresh for Contour 0.6-beta.1. Fixes #171 #184

Merged
merged 5 commits into from
Jul 12, 2018
Merged

Conversation

rosskukulinski
Copy link
Contributor

Signed-off-by: Ross Kukulinski ross@kukulinski.com

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
docs/route.md Outdated
@@ -1,30 +1,50 @@
# Route Specification

The core of Gimbal is Routes, which allow traffic into one or more applications. This section will discuss how to utilize Kubernetes `Ingress` objects to create these routes.
The core of Gimbal is Ingressroutes, which allow traffic to be routed into one or more applications. This section will discuss how to utilize [Contour IngressRoute](https://github.com/heptio/contour/blob/master/docs/ingressroute.md) objects to create these definitions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/Ingressroutes/IngressRoutes

docs/route.md Outdated

Before beginning it is important to understand how service discovery functions within Gimbal. The Discoverer components should be deployed per upstream cluster. Once synchronized, services will show up in your team namespace with the cluster name appended.

For example, if a Kubernetes cluster is being discovered and there was a service named `s1` which existed in the namespace `team1`, in the cluster `node02`, once synchronized the service in the Gimbal cluster would be named `s1-node02`.
For example, if a Kubernetes cluster is being discovered and there was a service named `s1` which existed in the namespace `team1`, in the cluster `node02`, once synchronized the service in the Gimbal cluster would be named `s1-node02`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Services are: ${backend-name}-${service-name} so I think this example would be: node02-s1

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
@@ -1,6 +1,6 @@
# Teams with Gimbal

A key feature of Gimbal is team management. Teams should be able to configure and define their own Ingress resources within the Gimbal cluster without requiring an administrator to assist. To enable this, users should be allowed access only to specified namespaces in the Gimbal cluster. Within their respective namespaces, team members should be granted specific authorization to create Ingress routes and to view Services and Endpoints.
A key feature of Gimbal is team management. Teams should be able to configure and define their own IngressRoute resources within the Gimbal cluster without requiring an administrator to assist. To enable this, users should be allowed access only to specified namespaces in the Gimbal cluster. Within their respective namespaces, team members should be granted specific authorization to create IngressRoutes and to view Services and Endpoints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to mention here that teams need Admins to delegate Virtualhosts to them. It was discussed earlier in delegate section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
stevesloka
stevesloka previously approved these changes Jul 12, 2018
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
docs/route.md Outdated

## Basic Route
## Basic Routex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Routex/Route

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevesloka stevesloka merged commit 8953e22 into master Jul 12, 2018
@rosskukulinski rosskukulinski deleted the beta1-docs branch July 12, 2018 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants