This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add Liveness Probe #202
Merged
Add Liveness Probe #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbrand
reviewed
Jul 31, 2018
| <-stopCh | ||
| log.Info("Stopped OpenStack discoverer") | ||
| } | ||
|
|
||
| func healthzHandler(w http.ResponseWriter, r *http.Request) { | ||
| _, err := reconciler.ProjectLister.ListProjects() |
There was a problem hiding this comment.
Is it customary to discard this error? I am wondering if it makes sense to either log it or print it out in the HTTP response
There was a problem hiding this comment.
We could, the goal here is just to understand if the API is healthy or not. I'd expect the logic portions of the controller to log their errors in context.
There was a problem hiding this comment.
Yeah, that makes sense to me. I think we can move forward with discarding this error.
stevesloka
force-pushed
the
openstackAuth
branch
from
8afbdf3 to
67797a6
Compare
alexbrand
previously approved these changes
Aug 9, 2018
…a Probes Signed-off-by: Steve Sloka <steves@heptio.com>
Signed-off-by: Steve Sloka <steves@heptio.com>
stevesloka
force-pushed
the
openstackAuth
branch
from
67797a6 to
8e1b5b3
Compare
alexbrand
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142 by adding a
/healthzendpoint and a default liveness probe to the Openstack discoverer. This is should detect the issue when the discoverer cannot authenticate properly to Openstack and cause the pod to restart.