This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add flag to have openstack client re-auth when token expires #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
force-pushed
the
refreshToken
branch
from
0d5b4cb to
9e495a9
Compare
alexbrand
reviewed
Aug 23, 2018
| @@ -56,7 +56,7 @@ func (lrt *LogRoundTripper) RoundTrip(request *http.Request) (*http.Response, er | |||
|
|
|||
| if response.StatusCode == http.StatusUnauthorized { | |||
| if lrt.numReauthAttempts == 3 { | |||
| return response, fmt.Errorf("tried to re-authenticate 3 times with no success") | |||
| log.Fatal("tried to re-authenticate 3 times with no success") | |||
There was a problem hiding this comment.
I am not sure we should be calling os.Exit deep within a library. I'd rather see us handling this in main.go or somewhere higher in the call stack. However, getting this bubbled up to main might be complicated with our current design, as the reconciler doesn't return an error.
With all this said, wouldn't this be caught by the healthz + liveness probe?
Signed-off-by: Steve Sloka <steves@heptio.com>
stevesloka
force-pushed
the
refreshToken
branch
from
9e495a9 to
7e5f21d
Compare
|
@alexbrand I reverted that log.Fatal. The probe should be able to pick up the issue if the refresh token fails. |
alexbrand
approved these changes
Aug 23, 2018
This was referenced Aug 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207 by allowing the openstack client to automatically refresh the auth token. Also, if the auth fails more the 3 times, then the app will quit and be restarted.
Signed-off-by: Steve Sloka steves@heptio.com