This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add queue size prometheus metric #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
force-pushed
the
metricQueueSize
branch
from
ad0cee8 to
cf8f22f
Compare
Signed-off-by: Steve Sloka <steves@heptio.com>
stevesloka
force-pushed
the
metricQueueSize
branch
from
cf8f22f to
220f17b
Compare
alexbrand
reviewed
Apr 23, 2018
| @@ -45,6 +45,8 @@ var ( | |||
| discovererMetrics localmetrics.DiscovererMetrics | |||
| ) | |||
|
|
|||
| const clusterType = "kubernetes" | |||
There was a problem hiding this comment.
Seems like this could live inside k8s.NewController? Similar with the openstack one.
There was a problem hiding this comment.
yup it could, for openstack you would put into the Reconciler? I was trying to be explicit since the cmd was the entry point.
| @@ -52,17 +54,20 @@ func NewQueue(logger *logrus.Logger, clusterName string, kubeClient kubernetes.I | |||
| Threadiness: threadiness, | |||
| Metrics: metrics, | |||
| ClusterName: clusterName, | |||
| ClusterType: clusterType, | |||
| } | |||
| } | |||
|
|
|||
| // Action that is added to the queue for processing | |||
| type Action interface { | |||
There was a problem hiding this comment.
I am wondering if this should be called "Resource" or something... Not this PRs concern though
Signed-off-by: Steve Sloka <steves@heptio.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the queue size metric. Fixes #48
Signed-off-by: Steve Sloka steves@heptio.com