This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Api latency #58
Merged
Api latency #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Sloka <steves@heptio.com>
Signed-off-by: Steve Sloka <steves@heptio.com>
alexbrand
reviewed
Apr 24, 2018
| @@ -123,13 +124,16 @@ func main() { | |||
| osClient.HTTPClient.Transport = httpTransportWithCA(log, openstackCertificateAuthorityFile) | |||
| } | |||
|
|
|||
| osClient.HTTPClient = newHTTPClient() | |||
There was a problem hiding this comment.
I believe this will break the ability to provide a CA cert for use in the HTTP transport (L123). We should also make sure to respect the timeout passed via flag and set in L121.
Signed-off-by: Steve Sloka <steves@heptio.com>
Signed-off-by: Steve Sloka <steves@heptio.com>
Signed-off-by: Steve Sloka <steves@heptio.com>
|
@alexbrand I refactored the http client and also moved the |
alexbrand
reviewed
Apr 24, 2018
| if openstackCertificateAuthorityFile != "" { | ||
| osClient.HTTPClient.Transport = httpTransportWithCA(log, openstackCertificateAuthorityFile) | ||
| dClient.Transport = httpTransportWithCA(log, openstackCertificateAuthorityFile) |
There was a problem hiding this comment.
We will overwrite the openstack.LogRoundTripper that we are configuring in L126.
I think something like this would work?
transport := &openstack.LogRoundTripper{
RoundTripper: http.DefaultTransport,
Log: log,
ClusterName: clusterName,
ClusterType: clusterType,
Metrics: &discovererMetrics,
}
if openstackCertificateAuthorityFile != "" {
transport.RoundTripper = httpTransportWithCA(log, openstackCertificateAuthorityFile)
}
osClient.HTTPClient = http.Client{
Transport: transport,
Timeout: httpClientTimeout,
}
Signed-off-by: Steve Sloka <steves@heptio.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47