Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FootprintFilter breaks when there are invalid positions #203

Open
ntessore opened this issue Oct 2, 2024 · 0 comments · May be fixed by #202
Open

FootprintFilter breaks when there are invalid positions #203

ntessore opened this issue Oct 2, 2024 · 0 comments · May be fixed by #202
Assignees
@JaimeRZP
Labels
bug Something isn't working
Milestone
v24.2

Comments

@ntessore
Copy link
Contributor

ntessore commented Oct 2, 2024

The FootprintFilter breaks if there are invalid values in the position columns. Such values are otherwise allowed (e.g., in the mapping) when they come with a zero weight.

The FootprintFilter should similarly ignore such rows.
@ntessore ntessore added the bug Something isn't working label Oct 2, 2024
@ntessore ntessore added this to the v24.1.2 milestone Oct 2, 2024
@ntessore ntessore linked a pull request Oct 23, 2024 that will close this issue
Open
@ntessore ntessore modified the milestones: v24.1.2, v24.2 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaimeRZP JaimeRZP

Labels
bug Something isn't working
Projects
None yet
Milestone
v24.2
Development

Successfully merging a pull request may close this issue.

gh-203: FootprintFilter removes NaN's heracles-ec/heracles
2 participants
@ntessore @JaimeRZP