Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request size limit on API endpoints might be too tight #1048

Open
elmisback opened this issue Nov 15, 2024 · 2 comments
Open

Request size limit on API endpoints might be too tight #1048

elmisback opened this issue Nov 15, 2024 · 2 comments

Comments

@elmisback
Copy link
Collaborator

Not blocking for SC

Expressions with 5 or more variables seem to be crashing in Odyssey (no analyses come back) due to the request being too large. Maybe due to the "5 mb" size server request size limit set here:

(* 5 1024 1024)) ; 5 mb body size for det44 bench mark.

but the request is only 1.16 MB according to the networking tab?

Example expression in Odyssey: x + y + z + x1 + y1

Causes herbie-fp/odyssey#183

image

@elmisback
Copy link
Collaborator Author

@zaneenders zaneenders self-assigned this Nov 15, 2024
@pavpanchekha
Copy link
Contributor

Ok, just to clarify, I think the browser is sending too large a request, since it sends the whole pcontext in the request. It's not about receiving too large a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants