Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqrt(x*x) not improved correctly #220

Open
DerekJuba-NIST opened this issue Nov 17, 2024 · 2 comments
Open

sqrt(x*x) not improved correctly #220

DerekJuba-NIST opened this issue Nov 17, 2024 · 2 comments

Comments

@DerekJuba-NIST
Copy link

When using "improve" on sqrt(x*x), the returned result is x. The result should be abs(x), so the returned result has high error. The Herbie example at https://herbie.uwplse.org/ processes this correctly.

@elmisback
Copy link
Collaborator

Definitely a bug, thank you for reporting!

I confirmed that this is the result we are obtaining from the /alternatives endpoint, so it is a problem in Herbie. I will cross-file this with herbie-fp/herbie as an issue with that endpoint and close this issue once that issue is closed.

@zaneenders
Copy link
Contributor

I started looking into this.

@zaneenders zaneenders removed their assignment Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants