Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if HERMIT_IP is set and dhcpv4 feature is enabled #1253

Closed
jounathaen opened this issue Jun 5, 2024 · 0 comments · Fixed by #1254
Closed

Warn if HERMIT_IP is set and dhcpv4 feature is enabled #1253

jounathaen opened this issue Jun 5, 2024 · 0 comments · Fixed by #1254
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jounathaen
Copy link
Member

As dhcpv4 is a default feature, it is easy to forget that it is set. If one sets HERMIT_IP (orHERMIT_GATEWAY/HERMIT_MASK) with dhcpv4 enabled, the value from the environment is ignored.

I suggest emitting a warning if dhcpv4 is enabled and HERMIT_IP, HERMIT_GATEWAY, or HERMIT_MASK is set.

(Probably just needs a few lines in

pub(crate) fn create() -> NetworkState<'a> {
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant