Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry naked functions #222

Closed
mkroening opened this issue Jun 11, 2021 · 0 comments · Fixed by #231
Closed

Retry naked functions #222

mkroening opened this issue Jun 11, 2021 · 0 comments · Fixed by #231
Assignees

Comments

@mkroening
Copy link
Member

Naked functions have come a long way since #95.

There is rust-lang/rfcs#2972 and rust-lang/rust#79653 which help against misusing the feature. We have adapted it in eduOS successfully, making it possible to use const and sym operands in asm! blocks instead of having to resort to global symbols. We could also eliminate most, if not all, hard coded constants from assembly, making the code much easier to understand.

What do you think, @stlankes?

@mkroening mkroening self-assigned this Jun 11, 2021
@bors bors bot closed this as completed in e30332a Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant