Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlineMatch from: 1. Mode is 2, master is 1. #11

Open
theromis opened this issue Feb 7, 2023 · 2 comments
Open

OnlineMatch from: 1. Mode is 2, master is 1. #11

theromis opened this issue Feb 7, 2023 · 2 comments

Comments

@theromis
Copy link

theromis commented Feb 7, 2023

In godot 3.5.1 on Join always can see this error, but seems like rest of the app works

_process_rpc: RPC '_check_client_version' is not allowed on node /root/OnlineMatch from: 1. Mode is 2, master is 1.

Seem like it happens here https://github.com/heroiclabs/fishgame-godot/blob/main/autoload/OnlineMatch.gd#L240
because on Join my client app in master state

how I can fix it?

@theromis
Copy link
Author

theromis commented Feb 7, 2023

I think I know the problem:
_boot_with_error and _check_client_version always running on client
according to rpc_id(peer_id but marked as master.
as a quick fix both this functions should be changed to puppet because seems like this check is critical but as long term this check should be done on server not on the client side.

@theromis
Copy link
Author

theromis commented Feb 9, 2023

Created PR fixing this issue #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant