Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using regex for validation #178

Open
edmorley opened this issue Aug 21, 2023 · 0 comments · May be fixed by #255
Open

Stop using regex for validation #178

edmorley opened this issue Aug 21, 2023 · 0 comments · May be fixed by #255

Comments

@edmorley
Copy link
Member

edmorley commented Aug 21, 2023

This buildpack currently uses regex to validate Procfile contents:
https://github.com/heroku/procfile-cnb/blob/a1ee3659a5a95df96bf7b41a5f9dffb40678f4dd/src/procfile.rs#L38-L43

This causes quite a bit of buildpack bloat, particular with newer versions of the regex crate, which have gotten even larger (since by default it favours runtime performance for large/complex payloads/regex over compile time/binary size) - see #175 (comment).

The original reason for using regex was likely to ensure compatibility with the existing Codon Procfile parsing, however, (a) it would be easy to maintain that even without regex, (b) we've talked about wanting more strict parsing anyway (#73).

@schneems schneems linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant