Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New buildpack fails to run webpack command #778

Closed
vincentwoo opened this issue Jun 20, 2018 · 2 comments
Closed

New buildpack fails to run webpack command #778

vincentwoo opened this issue Jun 20, 2018 · 2 comments

Comments

@vincentwoo
Copy link

Post sprockets CVE, I have made only the following diff to my Rails app's production.rb:

   # Whether to fallback to assets pipeline if a precompiled asset is missed.
-  config.assets.compile = true
+  config.assets.compile = false

However, builds now seem to fail with this error:

remote:        Compiling…
remote:        Compilation failed:
remote:        error Command "webpack" not found.
remote:
remote:        yarn run v1.8.0
remote:        info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
remote:
remote:  !
remote:  !     Precompiling assets failed.
remote:  !
remote:  !     Push rejected, failed to compile Ruby app.
remote:
remote:  !     Push failed
remote: Verifying deploy...

Ironically, this is preventing us from deploying the relevant fix to Sprockets. Help would be urgently appreciated.

@vincentwoo
Copy link
Author

I should add that we have the Node buildpack at #1, with Ruby at #2, and that our binstubs are present and have been working without issue on all previous successful deploys.

@schneems
Copy link
Contributor

Thanks for opening the support ticket. It's much easier to diagnose these things with app logs.

If anyone else is seeing this try to replace heroku/ruby in your heroku buildpacks with https://github.com/heroku/heroku-buildpack-ruby#v186 which is the commit right before these changes went out. That will help determine if the latest buildpack deploy was the culprit.

Going to close this issue in favor of communicating over the support ticket. Sorry the app's not able to deploy right now, hopefully we'll get this resolved soon.

@schneems schneems closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants