-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Optimize AutoCompelete and Select components for large options. #3047
Comments
does this help? |
Async is still slow because it makes API calls, you could implement virtualization with react-window somehow. |
any updates? |
i'm also interested |
I'm interested too... I'm generating an AutoComplete with 1200 items and it's very, very slow. |
Hi @wingkwong, I am interested to take this and improve the time complexity for searching the options. Can I take this? Thank you! |
@vinroger assigned. please research a bit if react-aria has done something for the optimisation first. |
(Just an Addition) |
Hi @wingkwong, let me know if I could proceed with if yes I will submit the PR soon :) |
do you know why they marked as unstable? and what does it mean exactly?
I think better stick to RA implementation instead of third party one. |
Hi @wingkwong, Based on their release note on July 2024, the virtualizer component is "unstable" and they mentioned that it is not intended for public use. Link to RA release notes: https://react-spectrum.adobe.com/releases/2024-07-22.html "We are also working on bringing virtualization support to React Aria Components, which is available as an unstable API in this version." Here is a screenshot from the webpage: There is no mention of virtualizer update ever since. July 2024 was their second latest release. With this being said, should we still go with the virtualizer from react-aria, or should we consider alternative library? After deciding on this, I will submit the PR as soon as possible. Thank you - appreciate your help! :) |
Hi @wingkwong, I have opened a PR for this issue :) |
@jrgarciadev Does the Select component also work with isVirtualized after this PR? From the docs, it doesn't look like it. |
Is your feature request related to a problem? Please describe.
First of all, nice library. I would say I have been following this library before its birth. I love the way
Vuesax
looks, so I was looking for something similar in the React world. You came at the right time. Nice work once again!I have about
270,000+
options while using theAutocomplete
component. Before you call me crazy, I'm only fetching the data when the user inputs a search query. Again, I'm not crazy. I'm using debounce fromLodash
, and every good stuff that will make it work right. But, it is too slow. i mean very slow.Describe the solution you'd like
I would suggest making it efficient like
react-select
, I tried using it, but I did not get how to merge both. I wanted to have the functionalities of it +next UI
beautiful Autocomplete component.I don't mind if someone could provide an example
Describe alternatives you've considered
react-select
Screenshots or Videos
No response
The text was updated successfully, but these errors were encountered: