Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - 2.6.4 Cached Avatars Still Flickering #4271

Closed
daveycodez opened this issue Dec 7, 2024 · 8 comments · Fixed by #4442
Closed

[BUG] - 2.6.4 Cached Avatars Still Flickering #4271

daveycodez opened this issue Dec 7, 2024 · 8 comments · Fixed by #4442
Assignees
Labels
✨ Type: Enhancement New enhancement on existing codebase

Comments

@daveycodez
Copy link

NextUI Version

2.6.4

Describe the bug

The previous issue was closed but I want to notify that this is still an issue in 2.6.4. Avatars that are cached should be rendered immediately but they are still fading in

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

Use any Avatar, Image, or User component

Expected behavior

Cached avatars should be instantly rendered

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

Copy link

linear bot commented Dec 7, 2024

@daveycodez
Copy link
Author

#3987

@wingkwong
Copy link
Member

seems the changes caused image ReferenceError in SSR and got rollbacked in #4122

@daveycodez
Copy link
Author

daveycodez commented Dec 8, 2024

My fix can be seen here:

https://github.com/daveyplate/nextui-fixed-avatar/blob/main/src/avatar.jsx

For SSR mainly I am using a hook called useIsHydrated and only referencing Image when isHydrated is true

@wingkwong
Copy link
Member

can you create a PR for us to review?

@daveycodez
Copy link
Author

can you create a PR for us to review?

I haven't made a PR here before I'm not sure the exact steps

@jrgarciadev jrgarciadev added the Bug label Dec 16, 2024 — with Linear
@wingkwong wingkwong added ✨ Type: Enhancement New enhancement on existing codebase and removed Bug labels Dec 16, 2024
@daveycodez
Copy link
Author

daveycodez commented Dec 23, 2024

Is there any way we can get this feature for 2025? Images and Avatars are pretty much unusable without this. If you guys merge this by January 5th I will buy one additional Organization Plan of NextUI Pro.

Also, this is 1000% a bug

@jrgarciadev @wingkwong

@wingkwong
Copy link
Member

@daveycodez Sorry for the late reply. I'll take a look this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Type: Enhancement New enhancement on existing codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants