Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify mcl_c.js and mcl_c512.js to reduce error size #11

Closed
jochem-brouwer opened this issue Jun 20, 2020 · 4 comments
Closed

Beautify mcl_c.js and mcl_c512.js to reduce error size #11

jochem-brouwer opened this issue Jun 20, 2020 · 4 comments

Comments

@jochem-brouwer
Copy link

When a function of this package throws, these mcl_c.js or mcl_c512.js seem to throw aswell. Since these scripts do not seem to be beautified, they throw a gigantic error string. Is it possible to "beautify" (i.e. add newlines) these scripts, so the error size reduces?

@herumi
Copy link
Owner

herumi commented Jun 21, 2020

mcl_c.js is automatically generated by Emscripten. mcl.js returns a small error. What process causes a large error?

@herumi
Copy link
Owner

herumi commented Jun 22, 2020

Though I don't know what you want, I've removed mcl_c.js and mcl_c512.js and added mcl_c384_256.js.
It supports BN254, BN_ZSNARK, BLS12-381 curve.

@herumi
Copy link
Owner

herumi commented Jun 22, 2020

I understood what you mean. I changed the compiler option. Is it okay?

@jochem-brouwer
Copy link
Author

I'm sorry that I was not more clear. I just checked your upgrade; this is exactly what I meant and solves the problem. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants