Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX10.2 support #192

Closed
busykai opened this issue Sep 5, 2024 · 8 comments
Closed

AVX10.2 support #192

busykai opened this issue Sep 5, 2024 · 8 comments

Comments

@busykai
Copy link

busykai commented Sep 5, 2024

Hello @herumi;

now that AVX10.2 specification as well as SDE version which supports AVX10.2 are released, could we hope for support for AVX10.2? Do you have plans to work on it?

@herumi
Copy link
Owner

herumi commented Sep 7, 2024

I've already skimmed through that PDF, but it has too many pages.
I will support them little by little.
Is there a diff list of really new instructions for AVX10.2 from AVX-512?
For example, AVX10 NEW INSTRUCTION FORMS has vaddpd, but that is the same as an existing instruction, right?

By the way, Intel is a heavy user of Xbyak (thank you), but would your company be interested in sponsoring my contributions?
For example, Xbyak is received Google Open Source Peer Bonus Awards 2024.
https://opensource.googleblog.com/2024/06/google-open-source-peer-bonus-program-first-group-2024-recipients.html .

@busykai
Copy link
Author

busykai commented Sep 14, 2024

Some of the instruction that used to be "extensions" are brought in under 10.2 umbrella, it is generally part of AVX10 strategy: simplify capability detection. So instead of checking for AVX512VL and AVX512F, one would just check for AVX10.2 or higher. This was done starting AVX10.1 (which was all existing instructions). So yes, some of the instructions mentioned in the AVX10.2 spec are existing instructions.

By the way, Intel is a heavy user of Xbyak (thank you), but would your company be interested in sponsoring my contributions?

I am an employee and cannot speak on behalf of the company, nor I can make these decisions. What I can do is to ask around to see what can be done. Your project provides significant value to the area I am working on (so, thank you!).

@herumi
Copy link
Owner

herumi commented Sep 18, 2024

What I can do is to ask around to see what can be done. Your project provides significant value to the area I am working on (so, thank you!).

Thank you very much. That will be sufficient.

@herumi
Copy link
Owner

herumi commented Oct 8, 2024

@busykai
I've started working on AVX10.2 support, but are there any specific instruction sets that would be particularly beneficial to implement first?

@herumi
Copy link
Owner

herumi commented Oct 15, 2024

The latest version, v7.20, fully supported AVX10.2.
Could you try it?

@busykai
Copy link
Author

busykai commented Oct 18, 2024

Thank you! Will try to do it the next week. This is great!

I'm closing this issue since this is done!!!

@busykai busykai closed this as completed Oct 18, 2024
@herumi
Copy link
Owner

herumi commented Oct 18, 2024

@busykai
I have one remark.
After Xbyak v7.20 was released, the AVX10.2 rev. 2 specification was updated.
This update fixes the encoding of some mnemonics such as vcomx*.
I have already implemented these changes in the dev branch to comply with the new specification.
However, since Intel XED hasn't been updated yet, I cannot verify the correctness of these changes.
Would you be able to verify these modifications? If so, I can merge them into the master branch.

@herumi herumi reopened this Oct 18, 2024
@herumi
Copy link
Owner

herumi commented Nov 11, 2024

I tested them with xed 2024.11.4.

@herumi herumi closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants