Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow formatting a volume without automounting it #530

Merged
merged 2 commits into from
Aug 17, 2023
Merged

feat: allow formatting a volume without automounting it #530

merged 2 commits into from
Aug 17, 2023

Conversation

marvinruder
Copy link
Contributor

@marvinruder marvinruder commented Aug 15, 2023 •
edited
Loading

To Do

  • document supported volume formats (this can be done either hard-coded or fetched from somewhere, but that may require changing the REST API service, so I left that open for now)

@marvinruder
Allow formatting a volume without automounting it
d90f553 
* Fixes #529
* TODO: document supported volume formats
apricote
apricote reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! You are right, it makes no sense to restrict formatting to automounted volumes.

internal/cmd/volume/create.go Outdated Show resolved Hide resolved
@marvinruder
Document supported volume formats
57748b7 
* Add to flag description
* Add as shell completion

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
@apricote apricote changed the title Allow formatting a volume without automounting it feat: allow formatting a volume without automounting it Aug 17, 2023
@apricote apricote merged commit a435c9a into hetznercloud:main Aug 17, 2023
1 of 2 checks passed
@hcloud-bot hcloud-bot mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting a volume without automounting is not possible
2 participants
@marvinruder @apricote