Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primary-ip): allow setting auto-delete on create #860

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 6, 2024

Closes #855

@phm07 phm07 requested a review from a team as a code owner September 6, 2024 09:03
@phm07 phm07 self-assigned this Sep 6, 2024
@phm07 phm07 added the feature label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (b59cfbf) to head (bfe82fc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   61.49%   61.51%   +0.01%     
==========================================
  Files         238      238              
  Lines        8522     8526       +4     
==========================================
+ Hits         5241     5245       +4     
  Misses       2572     2572              
  Partials      709      709              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit b6aecb3 into main Sep 12, 2024
5 checks passed
@phm07 phm07 deleted the primary-ip-create-auto-delete branch September 12, 2024 08:11
phm07 pushed a commit that referenced this pull request Oct 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.48.0](v1.47.0...v1.48.0)
(2024-10-25)


### Features

* allow auto-completing context flag
([#861](#861))
([7495b14](7495b14))
* **primary-ip:** allow setting auto-delete on create
([#860](#860))
([b6aecb3](b6aecb3)),
closes [#855](#855)


### Bug Fixes

* **image:** only use numerical IDs for label auto-completion
([#865](#865))
([1d10d92](1d10d92))
* **primary-ip:** labels ignored in create command
([#885](#885))
([7a17174](7a17174)),
closes [#883](#883)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(primary-ip): allow setting auto-delete on create
2 participants