feat(helm): allow to manually set network name or ID #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitwegner
changed the title
apricote
changed the title
apricote
requested changes
Jun 16, 2023
There was a problem hiding this comment.
Looking good in general @pitwegner :) Thanks for the contribution! I have some small requests before we can merge this.
|
Ah yes, our e2e tests are currently broken for PRs from forks. Sorry about that. I will run them locally and report back :) |
apricote
approved these changes
Jun 16, 2023
|
Oh yea, linting fails because of #459. |
apricote
pushed a commit
that referenced
this pull request
Jun 16, 2023
🤖 I have created a release *beep* *boop* --- ## [1.16.0](v1.15.0-rc.0...v1.16.0) (2023-06-16) ### Features * **helm:** allow to manually set network name or ID ([#458](#458)) ([8410277](8410277)) ### Bug Fixes * **ci:** qemu binfmt wrappers during release ([#421](#421)) ([84a7541](84a7541)) * **routes:** Only delete routes in the Cluster CIDR ([#432](#432)) ([c35d292](c35d292)) ### Continuous Integration * setup release-please ([#437](#437)) ([bbec89e](bbec89e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Hetzner Cloud Bot <45457231+hcloud-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.