feat(helm): remove "v" prefix from chart version

[kranurag7]

This commit updates the chart version of hcloud-cloud-controller-manager We only need to update the version in Chart.yaml because goreleaser already strips the v from {{ .Version }}

To patch the extra v with image tag, I updated the template to use tag: 'v{{ $.Chart.Version }}'

Ref: https://goreleaser.com/customization/release/#github
Above, the name template looks something like this.

name_template: "{{.ProjectName}}-v{{.Version}} {{.Env.USER}}"

On packer-plugin-hcloud we manually include v in the binary name.
https://github.com/syself/packer-plugin-hcloud/blob/7a934739f43c36e2818d1816f22d388231e2eac1/.goreleaser.yml#L28

Release Assets for packer-plugin-hcloud

So, IMHO, we don't need to make any change in .goreleaser.yaml
For testing and Ref:
I created a snapshot release locally using goreleaser release --snapshot and the diff updates the chart version and image tag as per the requirement described in the issue.

Attached Screenshot

Fixes #529

[apricote]

Hey @kranurag7,

thanks for the PR! I think we do need to make some changes in the goreleaser configuration, because we explicitly added the v back into the version when calling scripts/release-generate-deployment-yamls.sh and ./scripts/publish-helm-chart.sh. See my comment #529 (comment)

The first script actually overwrites the version in Chart.yaml to be whatever the script was called with, currently including the v:

hcloud-cloud-controller-manager/scripts/release-generate-deployment-yamls.sh

Line 15 in 07a3df9

sed -e "s/version: .*/version: $VERSION/" --in-place chart/Chart.yaml

I also think this is worth pointing out in the release notes, so I will update the title of this PR to feat(helm): remove "v" prefix from chart version.

[apricote]

Hey @kranurag7, do you have some time to work on this within the next week? Otherwise I would implement the fixes to make sure this will be included in the next version.

[kranurag7]

This PR was always in back of my head but I was little busy. I'll for sure push the changes tomorrow.

[kranurag7]

@apricote I tried, this today, but I was not able to test this entirely on my machine (probably my issues with Docker buildx build). I just removed things as per your issue feedback and some minor tinkering with the scripts.
If you intend to create a release soon, then please feel free to add additional commits and proceed with the release.
I'm just one ping away if there's anything where I can be helpful.

[apricote]

Yea, running the goreleaser config outside of CI (and without actually publishing something) is a PITA :(

Changes look good, i will push one more cleanup commit and then do a release-candidate to verify its working 🚀

Thanks for the patches!

[apricote]

Building the Helm chart with the new version was successful :)

➜ helm search repo hcloud --versions --devel | grep 1.19
hcloud/hcloud-cloud-controller-manager  1.19.0-rc.0