is_current('') is always true, regardless of current page url

[webuniverseio]

I expect that is_current('') should return false for pages like /about/, /contact, etc... Do I misunderstand something? Thank you.

[kokjinsam]

I encountered this problem as well.

[kokjinsam]

in order to make this work, I had to do this is_current('about/index.html') which seems to me a little bit counter-intuitive.

[dcanetma]

Here's a sample using EJS that seems to work.

		<% if(site.data.menu) {%>
			  <ul class="navbar-nav ml-auto">
			  	<% for (link in site.data.menu) { %>
				  	<li class="nav-item <%- is_current(site.data.menu[link]+'/index.html') ? 'active' : '' %>">
				  		<a class="nav-link" href="<%= config.root %><%= site.data.menu[link] %>" title="Go to <%= link %> page"><%= link %></a>
				  	</li>
					<% } %>
			  </ul>
	  <% } %>

[stevenjoezhang]

is_current('') is always true

hexo/lib/plugins/helper/is.js

Lines 3 to 20 in c0bf222

	function isCurrentHelper(path = '/', strict) {
	const currentPath = this.path.replace(/^[^/].*/, '/$&');
	if (strict) {
	if (path[path.length - 1] === '/') path += 'index.html';
	path = path.replace(/^[^/].*/, '/$&');
	return currentPath === path;
	}
	path = path.replace(/\/index\.html$/, '/');
	if (path === '/') return currentPath === '/index.html';
	path = path.replace(/^[^/].*/, '/$&');
	return currentPath.startsWith(path);
	}

https://hexo.io/docs/helpers#is-current