Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure after upgrade hexo-fs 0.2.3 to 1.0.1 #3392

Closed
yoshinorin opened this issue Dec 17, 2018 · 7 comments
Closed

CI failure after upgrade hexo-fs 0.2.3 to 1.0.1 #3392

yoshinorin opened this issue Dec 17, 2018 · 7 comments

Comments

@yoshinorin
Copy link
Member

yoshinorin commented Dec 17, 2018

Detail

Some test failing caused by hexo-fs version up.
I tried to downgrade hexo-fs from 1.0.1 to 0.2.3. And test are pass after downgrade.

hexo-fs upgraded 2 month ago. But, test failed since 5 days ago. This time lag maybe caused by CI cache.

@segayuu, @tomap, @JLHwung , @tcrowe
You committed or approval some changes between 0.2.3 and 1.0.1
Do you know anything about it?

@tcrowe
Copy link
Contributor

tcrowe commented Dec 17, 2018

I'm investigating these tests, @yoshinorin, and I'll update you when I solve the problem.

@tcrowe
Copy link
Contributor

tcrowe commented Dec 17, 2018

Sometimes the package.json doesn't exist when it tries to update it:
https://github.com/hexojs/hexo/blob/master/lib/hexo/index.js#L168

Sometimes hexo-fs#writeFile does not write anything here:
https://github.com/hexojs/hexo/blob/master/lib/hexo/post.js#L77

I tried for a while to figure it out but I didn't come up with a solution yet. I'll try again soon.

@tcrowe
Copy link
Contributor

tcrowe commented Dec 18, 2018

@segayuu segayuu pinned this issue Dec 18, 2018
@segayuu segayuu unpinned this issue Dec 18, 2018
@yoshinorin yoshinorin changed the title CI failure after upgrade hexo-fs 0.2.3 to 1.0.0 CI failure after upgrade hexo-fs 0.2.3 to 1.0.1 Dec 18, 2018
@yoshinorin
Copy link
Member Author

Maybe this problem caused by this commit. And it change in hexo-fs 1.0.1.

@segayuu
How do you think ? Do you have any ideas ? For example revert etc...

@NoahDragon
Copy link
Member

@yoshinorin you are right, when I revert that change, the test failures are gone. I will revert that change, and publish a new npm package.

@NoahDragon
Copy link
Member

hexo-fs 1.0.2 has published. The change is only reverted the highlighted commit.

@yoshinorin
Copy link
Member Author

@NoahDragon
Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants