Fix country_options_for_select for when selected = nil (the default) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selected (btw renamed selected_country_code), ISO3166::Country[selected_country_code] would return false, hence false.name was failing.
hexorx
added a commit
that referenced
this pull request
Mar 1, 2013
Fix country_options_for_select for when selected = nil (the default)
|
Thank you! |
|
Any plan to release the 0.9.2 soon? :) |
|
I have been traveling but should have time to push an update tonight. Thank you for your contributions! On Fri, Mar 1, 2013 at 3:24 AM, Rémy Coutable notifications@github.com
|
|
done! |
|
Awesome thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When
selected(btw renamedselected_country_code),ISO3166::Country[selected_country_code]would return false, hencefalse.namewas failing.Thank you!