Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bin/console from gemspec #571

Merged
merged 1 commit into from
Jan 28, 2019
Merged

remove bin/console from gemspec #571

merged 1 commit into from
Jan 28, 2019

Conversation

patleb
Copy link
Contributor

@patleb patleb commented Jan 28, 2019

bin/console shouldn't be packaged as an executable

bin/console shouldn't be packaged as an executable
Copy link
Collaborator

@rposborne rposborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's what you get for using default gemspecs.

@rposborne rposborne merged commit 7378880 into countries:master Jan 28, 2019
@davidstosik
Copy link

davidstosik commented Nov 1, 2019

Thanks for this! ❤️
Will we get a new release soon? 🙏

$ gem install cp8_cli
# ...
wisper's executable "console" conflicts with countries
Overwrite the executable? [yN]  N
ERROR:  Error installing cp8_cli:
        "console" from wisper conflicts with installed executable from countries                                                                              

(Ruby 2.6.5)

davidstosik added a commit to davidstosik/wisper that referenced this pull request Nov 1, 2019
See https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html

Here's a similar PR on another gem:
countries/countries#571

If both gems, `countries` and `wisper`, get installed in the same setup,
they end up conflicting with eash other:

```sh
$ gem install cp8_cli
wisper's executable "console" conflicts with countries
Overwrite the executable? [yN]  N
ERROR:  Error installing cp8_cli:
        "console" from wisper conflicts with installed executable from
	countries
```
anisharamnani pushed a commit to viewthespace/wisper that referenced this pull request Jan 18, 2022
See https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html

Here's a similar PR on another gem:
countries/countries#571

If both gems, `countries` and `wisper`, get installed in the same setup,
they end up conflicting with eash other:

```sh
$ gem install cp8_cli
wisper's executable "console" conflicts with countries
Overwrite the executable? [yN]  N
ERROR:  Error installing cp8_cli:
        "console" from wisper conflicts with installed executable from
	countries
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants