-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to ensure internal type is not mutated except in inplace operations #925
Comments
Merged
This was referenced Dec 24, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Several of the linked issues to #905 were related to the internal type being mutated by NumPy operations (see below). While #905 contained a provisional fix to this in the behavior of
__getattr__
, no tests to that effect were added. To fully resolve these related issues, tests should be added that NumPy operations do not mutate the internal type. While doing this, it may be a good idea to check non-NumPy operations as well to ensure that the internal type is only changed during explicitly in place operations.Supersedes #399, #481, #509, #622, #678
The text was updated successfully, but these errors were encountered: