Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea: refactor-out tox dependency from GitHub Actions unit test workflow #1338

Open
jayaddison opened this issue Oct 24, 2024 · 0 comments · May be fixed by #1339
Open

Idea: refactor-out tox dependency from GitHub Actions unit test workflow #1338

jayaddison opened this issue Oct 24, 2024 · 0 comments · May be fixed by #1339

Comments

@jayaddison
Copy link
Collaborator

We shouldn't require tox during our GitHub Actions unit test workflow any more. The tox.ini file contains a convenient CI-and-dev-workflow-compatible way to workaround an lxml issue on some MacOS versions, but that no longer appears required in CI (based on test results observed during #1309).

I think we can and should remove tox from the GitHub Actions unit test workflow, and I believe that this will allow most/all of the resulting workflows to each complete in a sub-one-minute duration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: refactor: remove GitHub Actions unit test workflow dependency on 'tox' hhursev/recipe-scrapers
1 participant
@jayaddison