Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelloFresh: Prep Time Issue #845

Closed
2 tasks done
Emalton opened this issue Sep 10, 2023 · 3 comments · Fixed by #876
Closed
2 tasks done

HelloFresh: Prep Time Issue #845

Emalton opened this issue Sep 10, 2023 · 3 comments · Fixed by #876
Assignees
Labels

Comments

@Emalton
Copy link

Emalton commented Sep 10, 2023

Pre-filing checks

  • I have searched for open issues that report the same problem
  • I have checked that the bug affects the latest version of the library

The URL of the recipe(s) that are not being scraped correctly

The results you expect to see
The prep time should be scraped as well instead of just the total time.

The results (including any Python error messages) that you are seeing
Only the Total Time is scraped from HelloFresh recipies.

@Emalton Emalton added the bug label Sep 10, 2023
@jayaddison
Copy link
Collaborator

Thanks for the bugreport @Emalton - I've been taking a look into this, and discovered a couple of things:

  • Although we autofill some schema.org metadata fields from websites, cookTime and prepTime aren't included in that list; only the totalTime is.
  • hellofresh in particular seem to have an HTML/metadata page layout where the schema.org recipe's totalTime in fact refers to the cooking time, and where prepTime is in a different part of the page.

I think it'd probably make sense to solve for the second problem only here, although this does also suggest that we might be able to expand the number of websites we support timings for by extending the autofill logic.

I haven't yet figured out where to retrieve the prepTime info from for hellofresh - the page data is quite densely packed. I'll spend a little bit more time on that today but can't guarantee when this will be fixed.

@Emalton
Copy link
Author

Emalton commented Sep 23, 2023

Sounds great jayaddison, appreciate the work you're doing and the update!

@jayaddison
Copy link
Collaborator

A fix for this is available in version 14.49.3 as published on PyPi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants