feat: add metadata task #838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
==========================================
- Coverage 68.41% 68.29% -0.13%
==========================================
Files 27 28 +1
Lines 3841 3858 +17
==========================================
+ Hits 2628 2635 +7
- Misses 929 939 +10
Partials 284 284 ☔ View full report in Codecov by Sentry. |
kamikazechaser
requested changes
Mar 10, 2024
There was a problem hiding this comment.
I would suggest using functional arguments. I would refactor this entire PR to use something like:
asynq.Metadata which implements Option
Anyways the API needs to be discussed first. The PR should definitely be non-breaking to be included in the next release.
| @@ -44,19 +48,21 @@ func (t *Task) ResultWriter() *ResultWriter { return t.w } | |||
|
|
|||
| // NewTask returns a new Task given a type name and payload data. | |||
| // Options can be passed to configure task processing behavior. | |||
| func NewTask(typename string, payload []byte, opts ...Option) *Task { | |||
| func NewTask(typename string, payload []byte, md Metadata, opts ...Option) *Task { | |||
There was a problem hiding this comment.
This is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A field has been introduced to the
Taskfor carrying values across API boundaries. It can be utilized to address cross-cutting concerns, including distributed tracing, as highlighted in issues #547 and #774 .