Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to mint markdown (md) objkts #1296

Open
fraguada opened this issue Oct 15, 2021 · 3 comments
Open

not able to mint markdown (md) objkts #1296

fraguada opened this issue Oct 15, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@fraguada
Copy link
Contributor

fraguada commented Oct 15, 2021

Describe the bug
md files seem to be supported, but it seems they cannot be minted as I get the message that the file format is invalid. I guess from this line: https://github.com/hicetnunc2000/hicetnunc/blob/main/src/pages/mint/index.js#L81
The file I was minting was the objkt-swap README.md, as a test.

The ALLOWED_MIMETYPES defined in constants.js has the following for md: MD : 'text/plain'

Trying to mint a .txt file of the same results in a blank page after hitting mint with multiple errors in the console:
image

UPDATE: submitted a PR to constants.js to fix the mimetype: #1297

Screenshots
Preview:
Screenshot 2021-10-15 at 13 20 28
After pressing mint:
Screenshot 2021-10-15 at 13 20 07

To Reproduce
Steps to reproduce the behavior:

  1. Go to the mint page and fill out some data
  2. Upload a markdown, md file
  3. Preview
  4. Hit mint

Expected behavior
Expected that if md files are supported, one should be able to mint them.

Desktop (please complete the following information):

  • OS: macos
  • Browser: Firefox
  • Version: 93.0
@fraguada fraguada added the bug Something isn't working label Oct 15, 2021
@crzypatchwork crzypatchwork self-assigned this Oct 18, 2021
@melMass
Copy link
Collaborator

melMass commented Apr 19, 2022

This has been merged!

@melMass melMass closed this as completed Apr 19, 2022
@crzypatchwork
Copy link
Contributor

crzypatchwork commented Apr 19, 2022

really? this is a really common bug while uploading files, where mimetypes are not recognisable

@melMass
Copy link
Collaborator

melMass commented Apr 20, 2022

Hmmm I'm not sure now 😆.
I will check it when I'm home, but I think it was addressed by Kyle a few weeks ago.

@melMass melMass reopened this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants