Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small camelcase issue in filename. #11

Closed
ChrisHagg opened this issue Dec 13, 2017 · 3 comments
Closed

Small camelcase issue in filename. #11

ChrisHagg opened this issue Dec 13, 2017 · 3 comments

Comments

@ChrisHagg
Copy link

ChrisHagg commented Dec 13, 2017

There seems to be a small camelcase issue with a filename:

transip/src/Model/Webhost.php

I believe this should be:
transip/src/Model/WebHost.php (uppercase H)

No problems with my local development environment (Laravel Homestead), it throws errors however on my server environment.

Hope this helps, thank you for your effort.

@hiddeco
Copy link
Owner

hiddeco commented Dec 20, 2017

@ChrisHagg thanks for the issue report, and my apologies for the late response. Can you provide more details about the errors you are experiencing on your server environment?

Looking at the official 'client' I believe you are correct, however I'd like to be able to verify the fix before releasing a new version.

@ChrisHagg
Copy link
Author

@hiddeco It seems unable to find the correct file due to the camelcase difference:

PHP Fatal error: Class 'TransIP\Model\WebHost' not found in [server path]/vendor/hiddeco/transip/src/Api/AbstractApi.php on line 36

In AbstractApi.php line 36:

Class 'TransIP\Model\WebHost' not found

When I change the filename as described above the problem is solved.

@hiddeco hiddeco mentioned this issue Jan 3, 2018
@hiddeco
Copy link
Owner

hiddeco commented Jan 3, 2018

@ChrisHagg there was indeed a CamelCase issue due to a typo in one of the class maps. I modified the class name and the FQCNs are now resolved through the ::class constant which should make it a bit harder to have these kind of bugs in the future.

Bugfix is available in the 5.6 release I just published. Thanks again for the issue report!

@hiddeco hiddeco closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants