Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Adding header guards to header files in include/runtime/cpu #448

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Fix] Adding header guards to header files in include/runtime/cpu #448

wants to merge 6 commits into from

Conversation

BolinSNLHM
Copy link
Contributor

While trying to benchmark Hidet on the CPU, I encountered some compilation errors caused by function re-definition. It was due to multiple same include statements within the same source.cc file.

I added the header guards to avoid the error.

@vadiklyutiy
Copy link
Collaborator

@BolinSNLHM
Is it actual PR?

@BolinSNLHM
Copy link
Contributor Author

@BolinSNLHM

Is it actual PR?

Yes but it was before I joined the company

@vadiklyutiy
Copy link
Collaborator

If so, maybe we can move it to CentML/hidet repo.
From the other side CPU is not the first target right now. So, can postpone it to when it would be actual

@BolinSNLHM
Copy link
Contributor Author

If so, maybe we can move it to CentML/hidet repo. From the other side CPU is not the first target right now. So, can postpone it to when it would be actual

Yes, that makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BolinSNLHM @vadiklyutiy