Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embeded Transaction from flows #1090

Closed
0xivanov opened this issue Oct 2, 2024 · 1 comment
Closed

Remove embeded Transaction from flows #1090

0xivanov opened this issue Oct 2, 2024 · 1 comment
Assignees
@0xivanov
Labels
bug Something isn't working
Milestone
v2.51.0

Comments

@0xivanov
Copy link
Contributor

0xivanov commented Oct 2, 2024 •
edited
Loading

Description

  • Currently we have some flows that are embedding Transaction in themselves. This allows a user to call functions like sign and freeze, but these functions would not work as expected because the parent Transaction cannot be shared for both Transactions in the flow.

Additional context

  • Embeded Transaction should be removed and the exposed APIs should be aligned with other SDKs.

No response

Hedera network

No response

Version

latest

Operating system

None
@0xivanov 0xivanov added the bug Something isn't working label Oct 2, 2024
@0xivanov 0xivanov self-assigned this Oct 2, 2024
@0xivanov 0xivanov changed the title Remove Transaction from transaction flows Remove embeded Transaction from flows Oct 2, 2024
@0xivanov 0xivanov added this to the v2.51.0 milestone Nov 12, 2024
@0xivanov
Copy link
Contributor Author

Fixed in #1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xivanov 0xivanov

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.51.0
Development

No branches or pull requests
1 participant
@0xivanov