Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for creating PublicKey from bytes #1166

Closed
0xivanov opened this issue Nov 26, 2024 · 0 comments · Fixed by #1192
Closed

Add validation for creating PublicKey from bytes #1166

0xivanov opened this issue Nov 26, 2024 · 0 comments · Fixed by #1192
Assignees
@gsstoykov
Labels
enhancement New feature or request
Milestone
v2.53.0

Comments

@0xivanov
Copy link
Contributor

0xivanov commented Nov 26, 2024 •
edited
Loading

Problem

A user may create invalid ECDSA or ED25519 Public Key from bytes.

Solution

Add validation for the above mentioned flows.

Alternatives

No response
@0xivanov 0xivanov added the enhancement New feature or request label Nov 26, 2024
@0xivanov 0xivanov added this to the v2.52.0 milestone Nov 26, 2024
@gsstoykov gsstoykov self-assigned this Nov 28, 2024
@0xivanov 0xivanov changed the title Add validation for creating PublicKey and PrivateKey from bytes Add validation for creating PublicKey from bytes Dec 2, 2024
@agadzhalov agadzhalov modified the milestones: v2.52.0, v2.53.0 Dec 10, 2024
@gsstoykov gsstoykov mentioned this issue Dec 18, 2024
Merged
2 tasks
@gsstoykov gsstoykov linked a pull request Dec 18, 2024 that will close this issue
feat: Added ECDSA PKey validation and unit test #1192
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsstoykov gsstoykov

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.53.0
Development

Successfully merging a pull request may close this issue.

feat: Added ECDSA PKey validation and unit test hiero-ledger/hiero-sdk-go
3 participants
@0xivanov @agadzhalov @gsstoykov