Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amm] Avoid phantom overflow with "mulDiv" function from PRBMath library #13

Open
PaulRBerg opened this issue May 21, 2021 · 0 comments
Open

[amm] Avoid phantom overflow with "mulDiv" function from PRBMath library #13

PaulRBerg opened this issue May 21, 2021 · 0 comments
Labels
enhancement Improvement for an existing feature or system package:amm

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented May 21, 2021 •
edited
Loading

That is, on line 254 in HifiPool.

This is not a priority because there isn't enough DAI or USDC in existence for a phantom overflow to be possible.
@PaulRBerg PaulRBerg transferred this issue from hifi-finance/hifi-amm Aug 9, 2021
@PaulRBerg PaulRBerg changed the title Use "mulDiv" to avoid phantom overflow [amm] Avoid phantom overflow with "mulDiv" function from PRBMath library Aug 9, 2021
@PaulRBerg PaulRBerg added enhancement Improvement for an existing feature or system package:amm labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement for an existing feature or system package:amm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg