Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #19

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Update README.md #19

merged 2 commits into from
Aug 23, 2022

Conversation

Normo
Copy link
Member

@Normo Normo commented Aug 23, 2022 •
edited
Loading

  • replace role name
  • formatting
  • add HIFSI to author section

Replace role name
15946f1 
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
@Normo Normo self-assigned this Aug 23, 2022
Update README.md
0f11f7e 
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
@Normo Normo changed the title Replace role name in README.md Update README.md Aug 23, 2022
christianhueserhzdr
christianhueserhzdr approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@christianhueserhzdr christianhueserhzdr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Norman @Normo, this change seems to be fine. What about the "All names should start with an uppercase letter." warnings? Do you need to address them in another PR? I'll approve this PR now.

@Normo Normo merged commit 9c01b32 into hifis-net:master Aug 23, 2022
@Normo Normo deleted the update-README branch August 23, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhueserhzdr christianhueserhzdr christianhueserhzdr approved these changes

Assignees

@Normo Normo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Normo @christianhueserhzdr