Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Avrohugger to RC12 for Instant type #381

Closed
zmccoy opened this issue Aug 24, 2018 · 2 comments
Closed

Upgrade Avrohugger to RC12 for Instant type #381

zmccoy opened this issue Aug 24, 2018 · 2 comments

Comments

@zmccoy
Copy link
Collaborator

zmccoy commented Aug 24, 2018 •
edited
Loading

When upgrading to Avrohugger 1.0.0-RC12 timestamp_ms in the AVDL will be turned into java.time.Instant rather than LocalDateTime. To keep backwards compatibility between versions I think we'd need to have both of those types be serialized/deserialized the same way.

I'd love for any feedback.
@zmccoy
Copy link
Collaborator Author

zmccoy commented Aug 24, 2018

I can start on the upgrade this weekend and see where I can get.

@fedefernandez
Copy link
Contributor

Thanks @zmccoy. I agree with you, the encoders defined in freestyle-rpc for LocalDateTime encode the values with the Timestamp millisecond precision approach.

https://avro.apache.org/docs/1.8.2/spec.html#Timestamp+%28millisecond+precision%29

@fedefernandez fedefernandez mentioned this issue Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zmccoy @fedefernandez