(swift) does not recognize core Apple foundational libraries

[AustinConlon]

I found this while writing this on Stack Overflow. I'm not sure what the root of the problem is, but I'm guessing it starts in the function signature. Here's the code:

func configuredGridCell() -> UICollectionView.CellRegistration<UICollectionViewCell, Emoji> {
    return UICollectionView.CellRegistration<UICollectionViewCell, Emoji> { (cell, indexPath, emoji) in
        var content = UIListContentConfiguration.cell()
        content.text = emoji.text
        content.textProperties.font = .boldSystemFont(ofSize: 38)
        content.textProperties.alignment = .center
        content.directionalLayoutMargins = .zero
        cell.contentConfiguration = content
        var background = UIBackgroundConfiguration.listPlainCell()
        background.cornerRadius = 8
        background.strokeColor = .systemGray3
        background.strokeWidth = 1.0 / cell.traitCollection.displayScale
        cell.backgroundConfiguration = background
    }
}

[joshgoebel]

Looks good to me... you need to tell it your code is Swift... otherwise it's auto-detected as ObjectiveC and that's obviously not doing what you wanted.

[joshgoebel]

Are all the same built-in classes equally valid in Swift as in ObjC?

  var API_CLASS = {
    className: 'built_in',
    begin: '\\b(AV|CA|CF|CG|CI|CL|CM|CN|CT|MK|MP|MTK|MTL|NS|SCN|SK|UI|WK|XC)\\w+',
  };

Right now Swift doesn't get any points for them while ObjC does which is why your code is being flagged as ObjC. (so many library mentions)

[AustinConlon]

you need to tell it your code is Swift

Since I encountered this as a Stack Overflow user, does this mean the question has to have the Swift tag?

[AustinConlon]

Are all the same built-in classes equally valid in Swift as in ObjC?

  var API_CLASS = {
    className: 'built_in',
    begin: '\\b(AV|CA|CF|CG|CI|CL|CM|CN|CT|MK|MP|MTK|MTL|NS|SCN|SK|UI|WK|XC)\\w+',
  };

Right now Swift doesn't get any points for them while ObjC does which is why your code is being flagged as ObjC. (so many library mentions)

There are a few new frameworks like WidgetKit which are Swift-only, but I'm not sure if that's part of the problem.

[joshgoebel]

Damn, my question was too broad. :-) All all the class prefixes listed there valid for use in Swift code also? I think you're saying the answer is yes?

I'm thinking we should add them to our Swift grammar so they can be highlighted and help out for auto-detecting, yes? Right now swift is highlighting them as "types" but they have no relevance score, so it doesn't make it more likely that your code is Swift like it would if we added those API classes as an explicit list.

[joshgoebel]

@AustinConlon Ping.

[AustinConlon]

Yup, all of the frameworks for those prefixes are Swift as well, none are exclusive to Objective-C.

[joshgoebel]

@AustinConlon Want to take a pass at making a PR to pull over that rule from Objective-C, and balance the languages out?

[AustinConlon]

Will do.

[joshgoebel]

And if you happened to have the time: #2819 :-)

[joshgoebel]

@svanimpe Any chance you might be willing to tackle this also? Should be easy.

[svanimpe]

I would prefer not to highlight these classes any differently. They are imported Objective-C types, not "built-in" to Swift in any way, and we don't even highlight the built-in types from the Standard Library.

Is it not enough that they're highlighted as types?

[joshgoebel]

The Foundational libraries are used often in both ObjC and Swift code so seeing them doesn't imply one language on the
other. They need to be added for their relevance, even if not highlighting.

Honestly I'd consider them in the same category of built-ins... thinking about Swift as a larger platform and what code is COMMON, not just the language itself. But at the very least we need the relevance to fix issues with ObjC claiming Swift code just because a lot of foundational classes are used.

[svanimpe]

So I could for example, highlight them as types, but match them separately for a relevance boost?

Import statements could also be relevance boosters:

import Foundation
import UIKit
import AppKit
import SwiftUI

However, since we're talking about highlighting code snippets here (not full projects), it's unlikely that these are present.

[joshgoebel]

Import statements could also be relevance boosters:

Many languages have imports though... it's the very unique apple names that matter, not the imports themselves.

However, since we're talking about highlighting code snippets here (not full projects), it's unlikely that these are present.

Exactly.

[joshgoebel]

So I could for example, highlight them as types, but match them separately for a relevance boost?

Sounds like a start.