Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes #847

Closed
tcurdt opened this issue May 12, 2015 · 2 comments
Closed

Quotes #847

tcurdt opened this issue May 12, 2015 · 2 comments
Labels

Comments

@tcurdt
Copy link

tcurdt commented May 12, 2015

The following html

<pre><code>def map
  "bla"
end
</code></pre>

comes out as

<pre><code><span class="hljs-function"><span class="hljs-keyword">def</span> <span class="hljs-title">map</span>  &amp;quot;bla&amp;quot;
<span class="hljs-keyword">end</span></span></code></pre>

The &amp;quot; is not right here.

This is via highlight.js 8.4.0 via gulp-highlight

├─┬ gulp-highlight@1.0.0
│ ├─┬ cheerio@0.18.0
│ │ ├─┬ CSSselect@0.4.1
│ │ │ ├── CSSwhat@0.4.7
│ │ │ └─┬ domutils@1.4.3
│ │ │   └── domelementtype@1.3.0
│ │ ├─┬ dom-serializer@0.0.1
│ │ │ └── domelementtype@1.1.3
│ │ ├── entities@1.1.1
│ │ ├─┬ htmlparser2@3.8.2
│ │ │ ├── domelementtype@1.3.0
│ │ │ ├── domhandler@2.3.0
│ │ │ ├── domutils@1.5.1
│ │ │ ├── entities@1.0.0
│ │ │ └─┬ readable-stream@1.1.13
│ │ │   ├── core-util-is@1.0.1
│ │ │   ├── inherits@2.0.1
│ │ │   ├── isarray@0.0.1
│ │ │   └── string_decoder@0.10.31
│ │ └── lodash@2.4.2
│ └── highlight.js@8.4.0
@Sannis
Copy link
Collaborator

Sannis commented May 13, 2015

Looks very strange. It works well in browser with both master and 8.4 version for me.

Please, specify which languages are included in your version and how are you do it.

@Sannis Sannis added the bug label May 13, 2015
@Sannis Sannis changed the title quotes Quotes May 13, 2015
@tcurdt
Copy link
Author

tcurdt commented May 13, 2015

After digging deeper I found the problem isn't really highlight.js.

markedjs/marked#590

Sorry for the noise.

@tcurdt tcurdt closed this as completed May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants