Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Langauge being overwritten #50

Open
JeffreyArts opened this issue Aug 20, 2024 · 1 comment
Open

Bug: Langauge being overwritten #50

JeffreyArts opened this issue Aug 20, 2024 · 1 comment

Comments

@JeffreyArts
Copy link

I've seen that this project is no longer maintained, but I wanted to share this experience nonetheless, so other people are aware of this.

When I specify typescript as a proptype it won't use it, but instead will (wrongfully) fall back to other registered plugins. I've made a demo repo where you can see this behavior. It also implements a native highlight solution, bypassing this component entirely.

Since this package is no longer maintained and the work-around is so simple. Maybe it is an idea that this plugin no longer should be recommended on the Readme of highlight.js?


You can clone the repo below to get a minified code-sample of the situation I'm describing.
https://github.com/JeffreyArts/demo-bug-vue-highlight-js

@joshgoebel
Copy link
Member

Maybe it is an idea that this plugin no longer should be recommended on the Readme of highlight.js?

Makes sense, we'd take a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants