Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linting Rules #28

Open
highvolt-dev opened this issue Dec 30, 2021 · 2 comments
Open

Add Linting Rules #28

highvolt-dev opened this issue Dec 30, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@highvolt-dev
Copy link
Owner

Add linting rules for better consistency of code. Incorporate in GitHub Actions.

@highvolt-dev highvolt-dev added the enhancement New feature or request label Dec 30, 2021
@asheingold
Copy link

Do you have a preferred rule set for linting?

@highvolt-dev
Copy link
Owner Author

@asheingold I don't, but if there are several competing opinionated rulesets and one contradicts the existing style more than the other (generates more linting errors), we may want to select the ruleset that most reflects the current codebase so as to minimize the amount of revisions that will be needed to pass the linting tests. That being said the current code was contributed by multiple people and we want consistency. I do like to see Pythonic/idiomatic code.

I don't want to get in the way of you contributing, so I am open-minded about the ruleset selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants