-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Command Localizations #1141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking a go at this.
There are quite a lot of little things that need fixing. Probably should run black after you are done too :)
Btw its worth noting that, despite the fact the docs don't mention this anywhere, this is actually an unreleased feature that they only documented for a public build-override based beta and therefore might not be merged for a bit (unless @davfsa is ok with merging a public beta but they did a public beta for threads and then made breaking changes 3 months down the line so public beta for discord doesn't guarantee that they won't break stuff). Also fun fact the build override for this has been broken by command search v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just going to leave this open until Discord roll out localization support, mostly because atm it will break android apps (before some version) if used
Summary
This PR is an implementation of Application Command Localization
Checklist
nox
and all the pipelines have passed.