Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Command Localizations #1141

Merged
merged 45 commits into from
Aug 20, 2022
Merged

Conversation

mrsrmn
Copy link
Contributor

@mrsrmn mrsrmn commented Apr 22, 2022

Summary

This PR is an implementation of Application Command Localization

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Copy link
Contributor

@thesadru thesadru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few changes are needed.

hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
hikari/impl/special_endpoints.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a go at this.

There are quite a lot of little things that need fixing. Probably should run black after you are done too :)

hikari/impl/special_endpoints.py Outdated Show resolved Hide resolved
hikari/api/rest.py Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_rest.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_rest.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_special_endpoints.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_special_endpoints.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_special_endpoints.py Outdated Show resolved Hide resolved
hikari/commands.py Outdated Show resolved Hide resolved
@mrsrmn mrsrmn requested a review from davfsa May 1, 2022 17:25
hikari/commands.py Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
@FasterSpeeding
Copy link
Collaborator

FasterSpeeding commented May 3, 2022

Btw its worth noting that, despite the fact the docs don't mention this anywhere, this is actually an unreleased feature that they only documented for a public build-override based beta and therefore might not be merged for a bit (unless @davfsa is ok with merging a public beta but they did a public beta for threads and then made breaking changes 3 months down the line so public beta for discord doesn't guarantee that they won't break stuff).

Also fun fact the build override for this has been broken by command search v2.

hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
hikari/impl/special_endpoints.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_rest.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_rest.py Outdated Show resolved Hide resolved
@mrsrmn mrsrmn requested a review from davfsa July 1, 2022 15:14
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
hikari/impl/special_endpoints.py Outdated Show resolved Hide resolved
@mrsrmn mrsrmn requested review from davfsa and FasterSpeeding July 1, 2022 19:58
davfsa
davfsa previously approved these changes Jul 11, 2022
davfsa
davfsa previously approved these changes Jul 15, 2022
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just going to leave this open until Discord roll out localization support, mostly because atm it will break android apps (before some version) if used

@FasterSpeeding FasterSpeeding enabled auto-merge (squash) August 20, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants