-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and improve rest lifetime #1230
Conversation
- Better global ratelimits - RESTApp now persists TCP and Client connections, as well as shared bucket manager - Authentication-aware bucket manager - Add example of oauth server
@FasterSpeeding tests still need to be done and will be off for the next couple of days, so dont think ill be able to work much, but would appreciate it if i could get a couple of eyes on it and some general feedback :) |
Signed-off-by: davfsa <davfsa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find anything obviously out of place here but this feels like a case that'll need to be battle tested in the real world so looks good to me
Summary
/callback
endpoint, due to it having 0 ratelimit (to improve memory)Checklist
nox
and all the pipelines have passed.