Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and improve rest lifetime #1230

Merged
merged 12 commits into from
Jan 1, 2023
Merged

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Jul 29, 2022

Summary

  • Move global ratelimit to bucket manager
  • RESTApp now persists TCP and Client connections, as well as shared bucket manager
  • Skip ratelimits for interactions /callback endpoint, due to it having 0 ratelimit (to improve memory)
  • Add example of oauth server

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

@davfsa davfsa added enhancement New feature or request optimization Optimizations to the code labels Jul 29, 2022
@davfsa davfsa marked this pull request as draft July 29, 2022 13:22
- Better global ratelimits
- RESTApp now persists TCP and Client connections, as well as shared bucket manager
- Authentication-aware bucket manager
- Add example of oauth server
@davfsa
Copy link
Member Author

davfsa commented Dec 16, 2022

@FasterSpeeding tests still need to be done and will be off for the next couple of days, so dont think ill be able to work much, but would appreciate it if i could get a couple of eyes on it and some general feedback :)

@davfsa davfsa marked this pull request as ready for review January 1, 2023 10:52
@davfsa davfsa requested a review from FasterSpeeding January 1, 2023 10:52
Copy link
Collaborator

@FasterSpeeding FasterSpeeding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find anything obviously out of place here but this feels like a case that'll need to be battle tested in the real world so looks good to me

@davfsa davfsa merged commit fe83246 into hikari-py:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Optimizations to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants