-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to save resources #1272
Conversation
Honestly I think I'm just gonna have to leave the tests up to somebody else to take care of cos I can't figure this out. I've emulated what you've done, and I'm getting all sorts of errors and have absolutely no idea what I'm doing wrong. |
@parafoxia mind pushing what you have (can be with broken tests too, or just skip them entirely). |
There's not much extra there, but that's where I got up to. The error it's giving is that the async context manager mock can't be used in async contexts. |
@FasterSpeeding, just bumping this as it's ready for review. |
Test cases for the specialisations? |
Working on those atm :) |
@FasterSpeeding tests done. I also found some bugs in the code, so some parts are update too :) |
5b603a4
to
9544f2d
Compare
Co-authored-by: Lucina <lucina@lmbyrne.dev> Signed-off-by: davfsa <davfsa@gmail.com>
Summary
This PR adds the ability to save attachments (and more generally, resources) to disk.
Resource.save()
methodResource.save()
andResource.read()
Checklist
nox
and all the pipelines have passed.Related issues
None