Support specifying with_counts and with_expiration in RESTClient.fetch_invite
#1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
reviewed
Oct 28, 2022
…hikari into fetch-invite-params
davfsa
changed the title
with_counts and with_expiration in RESTClient.fetch_invite
davfsa
changed the title
with_counts and with_expiration in RESTClient.fetch_invitewith_counts and with_expiration in RESTClient.fetch_invite
davfsa
previously approved these changes
Nov 5, 2022
davfsa
reviewed
Nov 5, 2022
Signed-off-by: davfsa <davfsa@gmail.com>
davfsa
previously approved these changes
Nov 5, 2022
davfsa
reviewed
Nov 6, 2022
Signed-off-by: davfsa <davfsa@gmail.com>
davfsa
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
API docs mention that Get Invite (
/invites/{invite.code}) has three parameters -with_counts,with_expiration, andguild_scheduled_event_id. The first two are hardcoded totruewhen the rest client's.fetch_invite()method is used (and makes no reference to the third).I have changed the method to default these two parameters to true, while still allowing them to be changed to false (although I'm not sure why anyone would want them to be false). It does reduce the chance for confusion though, as it wasn't immediately clear that the function already returned these two values.
Checklist
noxand all the pipelines have passed.Related issues
None