Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use attachment upload method when editing messages #1367

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Nov 20, 2022

Summary

I initially tried to bound the attachments to a message_id or an interaction ID to ensure that the attachments were (at least at some point) part of that message we are editing. This unfortunately was stopped by discord, as all the interactions use the application_id, not the interaction id :(

So this will have to work for now

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

@davfsa davfsa added the bug Something isn't working label Nov 20, 2022
@davfsa davfsa assigned davfsa and unassigned davfsa Nov 20, 2022
@davfsa davfsa enabled auto-merge (squash) November 20, 2022 14:34
@davfsa davfsa merged commit 8343302 into hikari-py:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants