Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect is_nsfw from threads #1386

Merged
merged 4 commits into from
Dec 4, 2022

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Dec 4, 2022

Summary

is_nsfw now also defaults to False when excluded from the payload. It seems like Discord will always send the nsfw field when it is set to True, but randomly exclude it when its False.

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

Closes #1328

@davfsa davfsa added the bug Something isn't working label Dec 4, 2022
@davfsa davfsa requested a review from FasterSpeeding December 4, 2022 01:44
@davfsa davfsa enabled auto-merge (squash) December 4, 2022 01:45
changes/1386.bugfix.md Outdated Show resolved Hide resolved
Signed-off-by: davfsa <davfsa@gmail.com>
@davfsa davfsa merged commit 507bf41 into hikari-py:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GuildThreadChannel.is_nsfw should be removed
2 participants