Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select menu V2 #1455

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Select menu V2 #1455

merged 1 commit into from
Feb 6, 2023

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Jan 5, 2023 •
edited
Loading

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

Closes #1451

@davfsa davfsa added the enhancement New feature or request label Jan 5, 2023
@davfsa davfsa force-pushed the task/selects-v2 branch 2 times, most recently from 7b02dfd to 7dd39ee Compare February 1, 2023 15:12
@davfsa
Copy link
Member Author

davfsa commented Feb 1, 2023

Missing some tests, but should be good for an initial review

@davfsa davfsa marked this pull request as ready for review February 1, 2023 15:12
@davfsa davfsa requested a review from FasterSpeeding February 1, 2023 15:12
@davfsa
Copy link
Member Author

davfsa commented Feb 1, 2023

CI Stuck

@davfsa davfsa closed this Feb 1, 2023
@davfsa davfsa reopened this Feb 1, 2023
FasterSpeeding
FasterSpeeding reviewed Feb 5, 2023
View reviewed changes
hikari/api/special_endpoints.py Show resolved Hide resolved
hikari/api/special_endpoints.py Show resolved Hide resolved
hikari/api/special_endpoints.py Show resolved Hide resolved
hikari/impl/entity_factory.py Show resolved Hide resolved
hikari/impl/special_endpoints.py Show resolved Hide resolved
hikari/interactions/command_interactions.py Show resolved Hide resolved
@davfsa davfsa force-pushed the task/selects-v2 branch 4 times, most recently from 3f1a537 to 8c9615f Compare February 6, 2023 01:26
@davfsa davfsa merged commit 17a1407 into hikari-py:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@null-domain null-domain null-domain left review comments

@FasterSpeeding FasterSpeeding FasterSpeeding approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement different types of selects (selects v2)
3 participants
@davfsa @FasterSpeeding @null-domain