Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DM_MESSAGES instead of PRIVATE_MESSAGES in documentation #1874

Merged
merged 5 commits into from
Apr 7, 2024
Merged

Use DM_MESSAGES instead of PRIVATE_MESSAGES in documentation #1874

merged 5 commits into from
Apr 7, 2024

Conversation

TheLovinator1
Copy link
Contributor

Summary

PRIVATE_MESSAGES got renamed to DM_MESSAGES 4 years ago :-)

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

#227

beagold
beagold previously approved these changes Apr 5, 2024
Copy link
Contributor

@beagold beagold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice catch! I'm surprised it went unnoticed for so long!

Everything looks good to me :)

@beagold
Copy link
Contributor

beagold commented Apr 5, 2024

Looking at the CI, it seems like the fragment changelog is missing.

You can read on how to add it here

@beagold
Copy link
Contributor

beagold commented Apr 7, 2024

Went ahead and added the changelog fragment myself. Thanks again for the pull request!

@FasterSpeeding FasterSpeeding enabled auto-merge (squash) April 7, 2024 15:42
beagold
beagold previously approved these changes Apr 7, 2024
Copy link
Contributor

@beagold beagold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the final approval!

@FasterSpeeding FasterSpeeding merged commit 4813504 into hikari-py:master Apr 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants