Add URL methods and properties for rich presence assets. #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
discord/discord-api-docs#4317 The "dynamic" asset urls haven't been documented yet and might not be complete so I'm just opening this as a draft encase anybody has objections on how this is structured or behaves. Plus i'm not too sure if I want to add these special cased urls to hikari.urls or not yet |
FasterSpeeding
commented
Jan 9, 2022
FasterSpeeding
commented
Jan 9, 2022
FasterSpeeding
commented
Jan 15, 2022
FasterSpeeding
commented
Jan 15, 2022
|
Lol tbh this is kinda fucked cause |
FasterSpeeding
force-pushed
the
task/asset-urls
branch
from
c0acee9 to
be68388
Compare
FasterSpeeding
force-pushed
the
task/asset-urls
branch
from
f35623c to
e3f77e7
Compare
davfsa
reviewed
Jan 30, 2022
davfsa
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues